[POS][Local Catalog] Repo for incremental sync timestamps #14511

samiuelson · 2025-08-22T16:39:11Z

POS Incremental Sync Timestamp Storage

Description

Summary

Implemented a repository system for storing and retrieving site-specific incremental sync timestamps for POS products and variations using DataStore preferences.

Changes

WooPosSyncTimestampRepository: Low-level repository for string timestamp storage with site-specific keys
WooPosSyncTimestampManager: High-level manager providing Date object API with GMT timezone handling

Key Features

Site-specific storage: Timestamps are isolated per site using dynamic key generation
Type-safe API: Date objects for convenience, strings for raw access
Error handling: Graceful null site handling with logging

Steps to reproduce

Testing information

This code is not used at the moment. Check if CI is green and if the code looks good.

The tests that have been performed

Above

Images/gif

N/A

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

wpmobilebot · 2025-08-22T16:46:39Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`a2d9caf`
	Direct Download	`woocommerce-wear-prototype-build-pr14511-a2d9caf.apk`

wpmobilebot · 2025-08-22T17:00:11Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`a2d9caf`
	Direct Download	`woocommerce-prototype-build-pr14511-a2d9caf.apk`

Copilot

Pull Request Overview

This PR implements a repository system for storing and retrieving site-specific incremental sync timestamps for POS products and variations using DataStore preferences.

Adds a low-level repository (WooPosSyncTimestampRepository) for string timestamp storage with site-specific keys
Implements a high-level manager (WooPosSyncTimestampManager) providing Date object API with GMT timezone handling
Includes comprehensive test coverage for the timestamp manager functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
WooPosSyncTimestampRepository.kt	Low-level repository for storing/retrieving site-specific timestamps using DataStore
WooPosSyncTimestampManager.kt	High-level manager providing Date object API with GMT formatting and parsing
WooPosSyncTimestampManagerTest.kt	Comprehensive unit tests for the timestamp manager functionality

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...ain/kotlin/com/woocommerce/android/ui/woopos/util/datastore/WooPosSyncTimestampRepository.kt

...c/main/kotlin/com/woocommerce/android/ui/woopos/util/datastore/WooPosSyncTimestampManager.kt

codecov-commenter · 2025-08-22T20:30:25Z

Codecov Report

❌ Patch coverage is 30.98592% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.89%. Comparing base (7f6538d) to head (a2d9caf).
⚠️ Report is 76 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...os/util/datastore/WooPosSyncTimestampRepository.kt	0.00%	49 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #14511      +/-   ##
============================================
- Coverage     37.89%   37.89%   -0.01%     
- Complexity     9362     9374      +12     
============================================
  Files          2024     2026       +2     
  Lines        113785   113856      +71     
  Branches      15092    15107      +15     
============================================
+ Hits          43121    43146      +25     
- Misses        66698    66745      +47     
+ Partials       3966     3965       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

malinajirka · 2025-08-25T14:03:08Z

...c/main/kotlin/com/woocommerce/android/ui/woopos/util/datastore/WooPosSyncTimestampManager.kt

+
+    suspend fun storeProductsLastSyncTimestamp(timestamp: Date) {
+        val timestampGmt: String = gmtDateFormat.format(timestamp)
+        timestampRepository.storeProductsLastSyncTimestamp(timestampGmt)


💡 I think storing formatted dates has some drawbacks, the main one is that we can't safely change the format without clearing the storage. I'd suggest storing just timestamps - milliseconds since 1970.

Considering Samuel is AFK, @kidinov could you double check my train of thoughts and share whether you agree with this suggestion before I make the change? Thanks!

Agree. Also timestamp just feels cleaner as we don't need to format anything, And btw, gmtDateFormat is not thread safe

Not related to this, but I just realized that even if the date is retrieved from the backend, it’s not something we control. Therefore, there’s no guarantee that the date will be accurate and can change in some cases

malinajirka · 2025-08-26T10:37:40Z

@kidinov I have updated the API to store timestamps (Long) instead of dates. I also replaced the thread-unsafe DateFormatter with the new java.time API. Since I made quite a few changes and Sam is AFK, would you mind taking over of the review of this PR?

...c/main/kotlin/com/woocommerce/android/ui/woopos/util/datastore/WooPosSyncTimestampManager.kt

kidinov

LGTM! I left a couple of questions

samiuelson added 2 commits August 22, 2025 18:37

Create repository for sync timestamps

102bce9

Add layer for processing String <-> Date (de)serialization

b844fa6

samiuelson requested a review from Copilot August 22, 2025 16:42

This comment was marked as outdated.

Sign in to view

samiuelson added 4 commits August 22, 2025 20:52

Handle null site case

be5980d

Improve data parsing exception handling

35b6cd1

Remove Singleton annotations

1ce3f7a

Add tests

9553a2e

samiuelson requested a review from Copilot August 22, 2025 19:14

samiuelson added this to the 23.2 milestone Aug 22, 2025

samiuelson added the feature: point of sale POS project label Aug 22, 2025

Copilot AI reviewed Aug 22, 2025

View reviewed changes

...ain/kotlin/com/woocommerce/android/ui/woopos/util/datastore/WooPosSyncTimestampRepository.kt Show resolved Hide resolved

...c/main/kotlin/com/woocommerce/android/ui/woopos/util/datastore/WooPosSyncTimestampManager.kt Outdated Show resolved Hide resolved

samiuelson marked this pull request as ready for review August 22, 2025 19:18

samiuelson requested a review from malinajirka August 22, 2025 19:18

Make date parser strict

0e9c15e

malinajirka self-assigned this Aug 25, 2025

malinajirka reviewed Aug 25, 2025

View reviewed changes

malinajirka added 2 commits August 26, 2025 12:35

Store timestamp instead of string date

544baa7

Update tests

a2d9caf

kidinov self-assigned this Aug 26, 2025

kidinov reviewed Aug 26, 2025

View reviewed changes

...c/main/kotlin/com/woocommerce/android/ui/woopos/util/datastore/WooPosSyncTimestampManager.kt Show resolved Hide resolved

kidinov reviewed Aug 26, 2025

View reviewed changes

...c/main/kotlin/com/woocommerce/android/ui/woopos/util/datastore/WooPosSyncTimestampManager.kt Show resolved Hide resolved

kidinov approved these changes Aug 26, 2025

View reviewed changes

malinajirka merged commit e50d4c3 into trunk Aug 28, 2025
17 checks passed

malinajirka deleted the pos-local-catalog-sync-timestamp-repo branch August 28, 2025 07:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[POS][Local Catalog] Repo for incremental sync timestamps #14511

[POS][Local Catalog] Repo for incremental sync timestamps #14511

Uh oh!

samiuelson commented Aug 22, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

wpmobilebot commented Aug 22, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Aug 22, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Aug 22, 2025 •

edited

Loading

Uh oh!

malinajirka Aug 25, 2025

Uh oh!

kidinov Aug 26, 2025

Uh oh!

malinajirka commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

kidinov left a comment

Uh oh!

Uh oh!

Uh oh!

[POS][Local Catalog] Repo for incremental sync timestamps #14511

[POS][Local Catalog] Repo for incremental sync timestamps #14511

Uh oh!

Conversation

samiuelson commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

POS Incremental Sync Timestamp Storage

Description

Summary

Changes

Key Features

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

Uh oh!

This comment was marked as outdated.

Uh oh!

wpmobilebot commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

malinajirka Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

malinajirka commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

kidinov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

samiuelson commented Aug 22, 2025 •

edited

Loading

wpmobilebot commented Aug 22, 2025 •

edited

Loading

wpmobilebot commented Aug 22, 2025 •

edited

Loading

codecov-commenter commented Aug 22, 2025 •

edited

Loading